fix(COD-6990): get the modified files compared to HEAD^1#265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the logic to get the list of modified files.
Before the changes, comparing
HEADwith${baseSha}will sometimes fail because${baseSha}is not always available on a shallow clone (with depth 2). This will sometimes lead to failures like this one here.With this pull request, the code is now getting the list of modified files by comparing
HEADandHEAD^1which will always be available because of the workflow is doing a checkout with depth 2.Tested here: https://github.com/lacework-dev/WebGoat/actions/runs/26878535025?pr=142