feat(cli): Add time filter to vulnerability host list-cve command #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
changed the title
afiune
reviewed
Dec 13, 2023
Contributor
afiune
left a comment
afiune
left a comment
There was a problem hiding this comment.
Could we please add a test like this one https://github.com/lacework/go-sdk/blob/main/integration/host_vulnerability_test.go#L57 with the new flags and a short time range? 2 hours or so
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
lacework vulnerability host list-cvescommand is timing out for some customers with a large amount of data. The command defaults to a 24 hour window. We can replicate this by calling the API with the same 24h window and it times out. Enable the start time, end time, and range flags to enable querying smaller amounts of data.How did you test this change?
Passed unit tests
Passed integration tests
Build CLI locally and manually tested the flags
Issue
https://lacework.atlassian.net/browse/LINK-2415
https://lacework.atlassian.net/browse/RAIN-91480