(LINK-4045) (CLI) Add new flag -use_storage_account_network_rules in Azure CLI. #1762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokesh-vadlamudi
force-pushed
the
lvadlamudi-LINK-4045
branch
3 times, most recently
from
6fe9746 to
d0a6ee7
Compare
lokesh-vadlamudi
force-pushed
the
lvadlamudi-LINK-4045
branch
from
d0a6ee7 to
a466977
Compare
lokesh-vadlamudi
changed the title
lokesh-vadlamudi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?
When the flag is set to false:
Flag is set to True - Storage account network rules set:
More Tests:
lacework generate cloud-account azure --noninteractive --activity_log --subscription_id 0c21d8f2-6a26-47b1-9d9c-ae935147b344
module "az_activity_log" {
source = "lacework/activity-log/azure"
version = "~> 3.0"
application_id = module.az_ad_application.application_id
application_password = module.az_ad_application.application_password
infrastructure_encryption_enabled = true
service_principal_id = module.az_ad_application.service_principal_id
storage_account_network_rule_ip_rules = ["4.53.23.186"]
use_existing_ad_application = true
use_storage_account_network_rules = true
}
lacework generate cloud-account azure --noninteractive --activity_log --use_storage_account_network_rules --subscription_id 0c21d8f2-6a26-47b1-9d9c-ae935147b344
module "az_activity_log" {
source = "lacework/activity-log/azure"
version = "~> 3.0"
application_id = module.az_ad_application.application_id
application_password = module.az_ad_application.application_password
infrastructure_encryption_enabled = true
service_principal_id = module.az_ad_application.service_principal_id
storage_account_network_rule_ip_rules = ["4.53.23.186"]
use_existing_ad_application = true
use_storage_account_network_rules = true
}
lacework generate cloud-account azure --noninteractive --activity_log --subscription_id 0c21d8f2-6a26-47b1-9d9c-ae935147b344 --use_storage_account_network_rules --storage_account_network_rule_ip_rules 9.8.8.8,9.9.9.9
module "az_activity_log" {
source = "lacework/activity-log/azure"
version = "~> 3.0"
application_id = module.az_ad_application.application_id
application_password = module.az_ad_application.application_password
infrastructure_encryption_enabled = true
service_principal_id = module.az_ad_application.service_principal_id
storage_account_network_rule_ip_rules = ["9.8.8.8", "9.9.9.9"]
use_existing_ad_application = true
use_storage_account_network_rules = true
}
Issue
(https://lacework.atlassian.net/browse/LINK-4045)