fix: Potentially uncaught exception in access token request #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alannix-lw
commented
Mar 20, 2021
alannix-lw
commented
- Fixes issue Exception Handling: local variable 'response' referenced before assignment #12
hazedav
reviewed
Mar 22, 2021
laceworksdk/http_session.py
Outdated
| if response: | ||
| raise ApiError(response) | ||
| else: | ||
| logger.error("Call to _get_access_token() returned no response.") |
Collaborator
There was a problem hiding this comment.
Should we raise an exception no matter what? Just raise a fancier Exception (ApiError) if we have a response?
except Exception:
if response:
raise ApiError(response)
raise
Contributor
Author
There was a problem hiding this comment.
Yep, of course - thank you!
alannix-lw
force-pushed
the
alannix-lw/response-exception-fix
branch
from
100d567 to
9ce4309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.