Fix 1.1 breaking change in upstream lacework_ecr_integration
#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgametrio
changed the title
lacework_ecr_integration
|
I get the same error, did you find a workaround? |
Author
|
@sbeaulie no unfortunately. I fixed the provider version to 1.0.1 to avoid that. |
Author
|
Given the improvement has been merged from another PR (#39) while improving docs and test, I'm closing this one. Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the release of
lacework/laceworkversion 1.1, a breaking change has been introduced to the resourcelacework_integration_ecr(commit reference)The change is that the previous map
limit_by_labelsgot replaced bylimit_by_labelblock. This module should update the usage oflacework_integration_ecrto comply with the breaking change.How did you test this change?
Locally doing a
terraform plan