fix: handle limit_by_label field change in terraform-provider #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-stewart
approved these changes
Nov 30, 2022
dmurray-lacework
force-pushed
the
limit_by_label
branch
from
0119891 to
06eb57a
Compare
Signed-off-by: Darren Murray <darren.murray@lacework.net>
dmurray-lacework
force-pushed
the
limit_by_label
branch
from
7bb8c89 to
f4b4e16
Compare
Signed-off-by: Darren Murray <darren.murray@lacework.net>
Merged
Contributor
|
This was essentially a breaking change since we changed the variable This should have been released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darren Murray darren.murray@lacework.net
Summary
The type of limit_by_labels field has been updated in the terraform-provider.
This change updates the type of limit_by_labels variable allowed by the module.
How did you test this change?
Add limit_by_labels to the examples,
run compatibility tests
run tf plan locally
run e2e
Issue