fix: derive bucket name for regional deployments #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alannix-lw
changed the title
alannix-lw
approved these changes
Jan 11, 2023
ammarekbote
force-pushed
the
fixBucketName
branch
2 times, most recently
from
74d5422 to
34f05b4
Compare
Signed-off-by: Ammar Ekbote <ammar.ekbote@lacework.net>
ammarekbote
force-pushed
the
fixBucketName
branch
from
34f05b4 to
e28b4bb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bucket missing for multi region deployment
How did you test this change?
Deployed the jobs with new changes and verified bucket is populated for all region jobs.
Issue
Bucket is not populated for cloud run jobs in multi region deployment