Allow scanner to terminate host compute instance #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilderj
approved these changes
Apr 21, 2023
Contributor
wilderj
left a comment
wilderj
left a comment
There was a problem hiding this comment.
Approved but not sure what the test failures are about (don't seem to have any relation to your changes)
ammarekbote
force-pushed
the
SelfTerminateHost
branch
from
ac7578d to
3cf3be9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add permissions to scanner role associated with service account used to launch compute instances.
This allows the scanner container to issue (self) deletion request once the scanning is done and reduce the cleanup time.
How did you test this change?
Verified no error messages seen while (self) deleting the compute instance