jsdom@9.4.5 breaks build ⚠️#195
Closed
greenkeeperio-bot wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
jsdom just published its new version 9.4.5.
This version is covered by your current version range and after updating it in your project the build kept failing.
It looks like your project, in its current form, is malfunctioning and this update didn’t really change that. I don’t want to leave you in the dark about updates though. I recommend you get your project passing and then check the impact of this update again.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 11 commits .
7f1b9999.4.5b8ef33bDispatch non-abort errors when loading6755690Version 9.4.4a701b4dFix leftover console statement77dff7eVersion 9.4.3f7de363Handle aborting resource loads during shutdown better78681e9Version 9.4.2e69834aUse strict Boolean comparisons for inline handler return values7a34069Fix for 404s in test files96b86a4Update tough-cookie minimum versiond0566d2Write a 404 in tests for not-found filesSee the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade