Skip to content
/ ecf Public
forked from eclipse-ecf/ecf

Add missing getInstance(String, Provider) method to SSLContextFactory#3

Draft
Copilot wants to merge 4 commits intomasterfrom
copilot/fix-issue-233
Draft

Add missing getInstance(String, Provider) method to SSLContextFactory#3
Copilot wants to merge 4 commits intomasterfrom
copilot/fix-issue-233

Conversation

Copy link

Copilot AI commented Nov 13, 2025

SSLContextFactory was incomplete—it exposed getInstance(String) and getInstance(String, String) from SSLContext but not getInstance(String, Provider).

Changes

  • SSLContextFactory interface: Added getInstance(String protocol, Provider provider) method signature matching SSLContext API
  • ECFSSLContextFactory implementation: Delegates to SSLContext.getInstance(protocol, provider) with null handling consistent with the underlying API
  • SSLContextFactoryTest: Added test case for the new method
  • Javadoc: Fixed incorrect link for getInstance(String, String) method

Usage

Provider provider = SSLContext.getDefault().getProvider();
SSLContext context = sslContextFactory.getInstance("TLS", provider);

Fixes eclipse-ecf#233

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • bndtools.org
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/ecf/ecf org.codehaus.plexus.classworlds.launcher.Launcher clean install -DskipTests (dns block)
  • repo.eclipse.org
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/ecf/ecf org.codehaus.plexus.classworlds.launcher.Launcher clean install -DskipTests (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Fix eclipse-ecf#233


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Nov 13, 2025
Copilot AI and others added 3 commits November 13, 2025 08:21
…extFactory

- Add missing getInstance method to SSLContextFactory interface
- Implement the method in ECFSSLContextFactory
- Add test case for the new method

Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue 233 in Eclipse ECF Add missing getInstance(String, Provider) method to SSLContextFactory Nov 13, 2025
Copilot AI requested a review from laeubi November 13, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSLContextFactory is missing getInstance(String protocol, Provider provider)

2 participants