Fix mbt L null row size consideration#1855
Merged
fspindle merged 1 commit intolagadic:masterfrom Dec 11, 2025
Merged
Conversation
Avoid stacking L matrix when the number of features is 0 Allows to fix the following issue for example occuring in testGenericTracker.cpp when GSL is used Occurs on Fedora 25 and centos 7.2 ci ./testGenericTracker trackerType_image: 1 useScanline: 0 use_depth: 0 use_mask: 0 use_color_image: 0 Load config file for camera 1: /builds/visp-ws/visp-images/mbt-depth/Castle-simu/Config/chateau.xml Load config file for camera 2: /builds/visp-ws/visp-images/mbt-depth/Castle-simu/Config/chateau_depth.xml *********** Parsing XML for ME projection error ************ projection_error : sample_step : 10 (default) projection_error : kernel_size : 5x5 (default) *********** Parsing XML for Edge Model-Based Tracker ************ me : mask : size : 5 me : mask : nb_mask : 180 me : range : tracking : 8 me : range : init range : 0 (default) me : sample : sample_step : 5 me : contrast : threshold type 1 me : contrast : threshold 5 me : contrast : min threshold -1 (default) me : contrast : threshold margin ratio -1 (default) me : contrast : mu1 0.5 me : contrast : mu2 0.5 camera : u0 : 320 camera : v0 : 240 camera : px : 700 camera : py : 700 face : Angle Appear : 85 face : Angle Disappear : 89 face : Near Clipping : 0.01 face : Far Clipping : 2 face : Fov Clipping : True lod : use lod : 0 (default) lod : min line length threshold : 50 (default) lod : min polygon area threshold : 2500 (default) *********** Parsing XML for ME projection error ************ projection_error : sample_step : 10 (default) projection_error : kernel_size : 5x5 (default) *********** Parsing XML for Depth Dense Model-Based Tracker ************ depth dense : sampling_step : step_X : 4 depth dense : sampling_step : step_Y : 4 camera : u0 : 320 camera : v0 : 240 camera : px : 700 camera : py : 700 face : Angle Appear : 85 face : Angle Disappear : 89 face : Near Clipping : 0.01 face : Far Clipping : 2 face : Fov Clipping : True lod : use lod : 0 (default) lod : min line length threshold : 50 (default) lod : min polygon area threshold : 2500 (default) > 14 points > 0 lines > 0 polygon lines > 5 polygon points > 0 cylinders > 0 circles > 14 points > 0 lines > 0 polygon lines > 5 polygon points > 0 cylinders > 0 circles > 10 points > 0 lines > 0 polygon lines > 4 polygon points > 0 cylinders > 10 points > 0 lines > 0 polygon lines > 4 polygon points > 0 cylinders gsl: view_source.c:63: ERROR: matrix dimension n1 must be positive integer Default GSL error handler invoked.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1855 +/- ##
===========================================
- Coverage 47.82% 33.21% -14.62%
===========================================
Files 532 465 -67
Lines 68920 65999 -2921
Branches 32182 28708 -3474
===========================================
- Hits 32963 21919 -11044
- Misses 31902 33543 +1641
- Partials 4055 10537 +6482 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid stacking L matrix when the number of features is 0
Allows to fix the following issue for example occuring in
testGenericTracker.cppwhen GSL is used.Occurs on the followings ci machines: Fedora 25 with GSL 2.1 and centos 7.2 with GSL 1.15