fix(ui): adapt layout heights for 14-inch MacBook screens#216
Conversation
WalkthroughThis PR updates the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
fix(ui): AppBar and BreadcrumbsFromUrl add density=compact to reduce vertical space fix(ui): AppFooter reduce height from 40px to 32px fix(ui): replace fixed data table heights (60vh, 75vh, 288px) with calc-based responsive heights fix(ui): WarehouseStatistics and ProjectStatistics use container-relative height with flex layout fix(ui): LoQEExplorer fix height and overflow for proper container sizing fix(ui): HomeStatistics reduce chart height from 180px to 140px fix(ui): ServerOverview add max-height with overflow-y auto fix(ui): ViewOverview remove double v-card-text wrapping fix(ui): ProjectManager add overflow-y auto to tabs window and height propagation for statistics tab fix(ui): TableVersioningVisualization fix snapshot-log ordering (topological) and remove diverge-pass double-draw
c9407df to
1368abe
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/pages/roles/index.vue (1)
2-2: Consider centralizing this viewport offset.Line 2 introduces another hardcoded offset (
100px), while other pages use different constants (140px,160px). Moving this into shared app config avoids drift and keeps layout tuning consistent.As per coding guidelines: "Use environment variables from
src/app.config.tsfor all configuration — do not hardcode values like API URLs or feature toggles".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/roles/index.vue` at line 2, Replace the hardcoded "100px" viewport offset in the roles page's v-row style with a shared constant from app.config.ts: add (or reuse) a named export like VIEWPORT_OFFSET in src/app.config.ts and import it into the roles component (the template using <v-row class="ml-1" style="max-height: calc(100vh - 100px); overflow-y: auto">). Use that constant to compute the max-height (e.g., calc(100vh - VIEWPORT_OFFSET)) via the component's script or a style binding so the offset is centralized and consistent with other pages.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/pages/loqe.vue`:
- Around line 2-8: The height calc on the <v-container> uses fallbacks of 48px
and 32px which causes an unintended 80px shrink when --v-layout-top /
--v-layout-bottom are unset; update the inline style for the height (the
"height: calc(...)" on the v-container) to use zero px fallbacks (e.g. default
to 0px for --v-layout-top and --v-layout-bottom) so the container doesn't lose
extra space when those CSS vars are missing.
---
Nitpick comments:
In `@src/pages/roles/index.vue`:
- Line 2: Replace the hardcoded "100px" viewport offset in the roles page's
v-row style with a shared constant from app.config.ts: add (or reuse) a named
export like VIEWPORT_OFFSET in src/app.config.ts and import it into the roles
component (the template using <v-row class="ml-1" style="max-height: calc(100vh
- 100px); overflow-y: auto">). Use that constant to compute the max-height
(e.g., calc(100vh - VIEWPORT_OFFSET)) via the component's script or a style
binding so the offset is centralized and consistent with other pages.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bf75809f-4a9a-467a-83d1-f8224042080c
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (10)
package.jsonsrc/components/Home.vuesrc/pages/loqe.vuesrc/pages/roles/index.vuesrc/pages/server-settings.vuesrc/pages/warehouse/[id].namespace.[nsid].table.[tid].vuesrc/pages/warehouse/[id].namespace.[nsid].view.[vid].vuesrc/pages/warehouse/[id].namespace.[nsid].vuesrc/pages/warehouse/[id].vuesrc/pages/warehouse/index.vue
fix(ui): AppBar and BreadcrumbsFromUrl add density=compact to reduce vertical space
fix(ui): AppFooter reduce height from 40px to 32px
fix(ui): replace fixed data table heights (60vh, 75vh, 288px) with calc-based responsive heights
fix(ui): WarehouseStatistics and ProjectStatistics use container-relative height with flex layout
fix(ui): LoQEExplorer fix height and overflow for proper container sizing
fix(ui): HomeStatistics reduce chart height from 180px to 140px
fix(ui): ServerOverview add max-height with overflow-y auto
fix(ui): ViewOverview remove double v-card-text wrapping
fix(ui): ProjectManager add overflow-y auto to tabs window and height propagation for statistics tab
fix(ui): TableVersioningVisualization fix snapshot-log ordering (topological) and remove diverge-pass double-draw
Summary by CodeRabbit
Style
Chores