Skip to content

[1.20.4] FastVector Y level assertion causes soft-locks #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emyfops merged 1 commit into from
Mar 8, 2025
Merged

[1.20.4] FastVector Y level assertion causes soft-locks #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions common/src/main/kotlin/com/lambda/util/world/Position.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,14 @@ internal const val Y_MASK = (1L shl Y_BITS) - 1L

internal const val MIN_X = -(1L shl X_BITS - 1)
internal const val MIN_Z = -(1L shl Z_BITS - 1)
internal const val MIN_Y = -(1L shl Y_BITS - 1)
internal const val MAX_X = (1L shl X_BITS - 1) - 1L
internal const val MAX_Z = (1L shl Z_BITS - 1) - 1L
internal const val MAX_Y = (1L shl Y_BITS - 1) - 1L

/**
* Creates a new position from the given coordinates.
*/
fun fastVectorOf(x: Long, y: Long, z: Long): FastVector {
require(x in MIN_X..MAX_X) { "X coordinate out of bounds for $X_BITS bits: $x" }
require(y in MIN_Y..MAX_Y) { "Y coordinate out of bounds for $Y_BITS bits: $y" }
require(z in MIN_Z..MAX_Z) { "Z coordinate out of bounds for $Z_BITS bits: $z" }

return ((x and X_MASK) shl X_SHIFT) or ((z and Z_MASK) shl Z_SHIFT) or (y and Y_MASK)
Expand Down