-
Notifications
You must be signed in to change notification settings - Fork 18
Testing pipeline #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing pipeline #110
Conversation
… into feature/tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces extensive unit tests for various mathematical, collection, and task-related utilities, while also refactoring some function and variable names for consistency across the codebase. Key changes include:
- Addition of comprehensive test suites for vector math, range functions, and collection utilities.
- Renaming of several methods (e.g. from “mod” to “remainder” and “setMaxSize” to “setSizeLimit”) to improve clarity.
- Minor refactorings in task and network modules to enhance state management and integration with the testing pipeline.
Reviewed Changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| common/src/test/kotlin/* | New test classes covering Vec3d/Vec2d operations, VarIntIterator, Task handling, ranges, and collection utilities. |
| common/src/main/kotlin/com/lambda/util/* | Renaming of functions and properties for improved clarity and consistency (e.g., mod → remainder, setMaxSize → setSizeLimit). |
| .github/workflows/build.yml | Adjustments to the build workflow and branch filters. |
Files not reviewed (2)
- common/build.gradle.kts: Language not supported
- gradle.properties: Language not supported
Comments suppressed due to low confidence (2)
common/src/main/kotlin/com/lambda/task/Task.kt:41
- [nitpick] Changing both 'subTasks' and 'state' from private to public may expose internal task state to external modification. Consider retaining encapsulation unless there is a deliberate need to modify these properties externally.
val subTasks = mutableListOf<Task<*>>()
var state = State.INIT
common/src/main/kotlin/com/lambda/util/VarIntIterator.kt:36
- [nitpick] The use of the variable 'size' as a counter for groups read is slightly ambiguous. Renaming it to 'groupCount' (or a similar name) would improve clarity.
value = value or ((b and SEGMENT_BIT) shl (size++ * 7))
has issues with mocking logging ingame thats why some tests are disabled for now
65878db to
fc78398
Compare
x