Skip to content

fix: incorrect rounding with imgui sliders #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emyfops merged 1 commit into from
Dec 14, 2025
Merged

fix: incorrect rounding with imgui sliders #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/kotlin/com/lambda/config/settings/numeric/DoubleSetting.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import com.lambda.config.Setting
import com.lambda.config.settings.NumericSetting
import com.lambda.gui.dsl.ImGuiBuilder
import com.lambda.util.extension.CommandBuilder
import com.lambda.util.math.MathUtils.roundToStep
import net.minecraft.command.CommandRegistryAccess
import kotlin.math.roundToInt

Expand All @@ -46,7 +47,9 @@ class DoubleSetting(
private var valueIndex: Int
get() = ((value - range.start) / step).roundToInt()
set(index) {
value = (range.start + index * step).coerceIn(range)
value = (range.start + index * step)
.roundToStep(step)
.coerceIn(range)
}

context(setting: Setting<*, Double>)
Expand Down
5 changes: 4 additions & 1 deletion src/main/kotlin/com/lambda/config/settings/numeric/FloatSetting.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import com.lambda.config.Setting
import com.lambda.config.settings.NumericSetting
import com.lambda.gui.dsl.ImGuiBuilder
import com.lambda.util.extension.CommandBuilder
import com.lambda.util.math.MathUtils.roundToStep
import net.minecraft.command.CommandRegistryAccess
import kotlin.math.roundToInt

Expand All @@ -45,7 +46,9 @@ class FloatSetting(
private var valueIndex: Int
get() = ((value - range.start) / step).roundToInt()
set(index) {
value = (range.start + index * step).coerceIn(range)
value = (range.start + index * step)
.roundToStep(step)
.coerceIn(range)
}

context(setting: Setting<*, Float>)
Expand Down
Loading