Skip to content

Conversation

@cattyngmd
Copy link
Contributor

@cattyngmd cattyngmd commented Dec 15, 2025

added following setting to hud modules:

  • Show Keybind to ModuleList
  • Average to FPS

@beanbag44
Copy link
Collaborator

Looks good, but sameLine() still gets called even when showKeybind is disabled, resulting in all modules being placed on the same line

@beanbag44 beanbag44 self-requested a review December 15, 2025 22:18
Copy link
Collaborator

@beanbag44 beanbag44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just the formatting for sameLine seems off. Thats all though

@cattyngmd
Copy link
Contributor Author

wtf it looked fine on my phone, never using github there

Copy link
Collaborator

@beanbag44 beanbag44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emyfops
Copy link
Collaborator

emyfops commented Dec 15, 2025

Could you use a LimitedDecayQueue for the average fps count? Could you also use monotonic kotlin times instead of longs?

@cattyngmd
Copy link
Contributor Author

LimitedDecayQueue uses millis so theres no point of using it in that case

@emyfops
Copy link
Collaborator

emyfops commented Dec 15, 2025

LimitedDecayQueue uses millis so theres no point of using it in that case

I meant to use the queue to store nanos, either way it shouldnt really matter for the accuracy

@emyfops emyfops merged commit 303a989 into lambda-client:1.21.5 Dec 16, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants