Skip to content

Conversation

@cattyngmd
Copy link
Contributor

No description provided.

@cattyngmd
Copy link
Contributor Author

also i think its better to move the withEpsilon method to some util for future use

@beanbag44
Copy link
Collaborator

Thanks, I tried this before, but it seemed to break something. However, this seems to work. withEpsilon could be moved to util/extension/Box and maybe rename it to shrinkByEpsilon or something similar. Prob also best to inline the function directly to shrinkByEpsilon(): Box = expand(-1e-7) as it's cleaner.

@beanbag44 beanbag44 self-requested a review December 15, 2025 22:12
Copy link
Collaborator

@beanbag44 beanbag44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@emyfops
Copy link
Collaborator

emyfops commented Dec 16, 2025

@cattyngmd why do we need to shrink the box by the smallest minecraft unit ? (or whatever this is called)

@cattyngmd
Copy link
Contributor Author

cattyngmd commented Dec 16, 2025

bcs minecraft shrinks entity collision box by epsilon when checking is it possible to place block. without accounting that, the surround will extend itself when it shouldn't
изображение

@emyfops emyfops merged commit 8d1a72d into lambda-client:1.21.5 Dec 16, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants