Skip to content

Upgrade React Router to v7 and fix version compatibility #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaruesink merged 1 commit into from
Jul 6, 2025
Merged

Upgrade React Router to v7 and fix version compatibility #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lambdacurry/forms",
"version": "0.17.1",
"version": "0.17.2",
"type": "module",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
Expand Down Expand Up @@ -42,6 +42,8 @@
},
"peerDependencies": {
"react": "^19.0.0",
"react-router": "^7.0.0",
"react-router-dom": "^7.0.0",
"remix-hook-form": "7.0.1"
Comment on lines +45 to 47
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Deduplicate react-router* between peerDependencies and dependencies

Listing the same modules in both peerDependencies and dependencies will make consumers install two copies of React Router, which can break hook identity checks and inflate bundle size. Keep them only in peerDependencies; if the library needs them for its own build/tests, move them to devDependencies.

   "remix-hook-form": "7.0.1"
 },
 "dependencies": {
@@
-    "react-router": "^7.6.3",
-    "react-router-dom": "^7.6.3",
+    // provided by the host app via peerDependencies – avoid duplication

Also applies to: 77-78

🤖 Prompt for AI Agents 
In packages/components/package.json around lines 45 to 47 and also lines 77 to
78, react-router and react-router-dom are listed in both peerDependencies and
dependencies, causing duplicate installations. Remove these packages from
dependencies and keep them only in peerDependencies. If the library requires
them for build or testing purposes, move them to devDependencies instead.

},
"dependencies": {
Expand Down Expand Up @@ -72,7 +74,8 @@
"next-themes": "^0.4.4",
"react-day-picker": "^9.7.0",
"react-hook-form": "^7.53.1",
"react-router": "^7.6.1",
"react-router": "^7.6.3",
"react-router-dom": "^7.6.3",
"remix-hook-form": "7.0.1",
"sonner": "^1.7.1",
"tailwind-merge": "^2.5.5",
Expand Down
Loading
Loading