Conversation
…tibility - Remove getDefaultClassNames import which was removed in react-day-picker v9 - Update Calendar component to use custom class names directly without merging with default classes - Update CalendarDayButton component to remove defaultClassNames usage - Maintains existing styling while ensuring compatibility with react-day-picker v9.7.0 Fixes build error: 'getDefaultClassNames' is not exported by react-day-picker
|
|
|
Caution Review failedThe pull request is closed. WalkthroughThe package version for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
📝 Storybook Preview: View Storybook This preview will be updated automatically when you push new changes to this PR.
|
|
@codegen-sh now let's bump the patch version with npm for the components package with a summary message of the change we made. do not publish that will happen in the pipeline, let's also run yarn install and make sure our yarn lock is up to date and just push back up
|
- Bump @lambdacurry/forms from 0.19.0 to 0.19.1 - Update yarn.lock with latest dependencies - Version bump includes fix for react-day-picker v9 compatibility
|
✅ Done! I've successfully:
🔄 View Updated PR #114 on Github 🔄 The PR now includes both the fix and the version bump. The pipeline can handle publishing when you're ready! 🚀 💻 View my work • 🛑 Stop • React 👍 or 👎 |
Problem
The build was failing with the following error when using
@lambdacurry/formsv0.19.0:This is because
getDefaultClassNameswas removed in react-day-picker v9, but the calendar component was still trying to import and use it.Solution
getDefaultClassNamesimport from react-day-pickerdefaultClassNamesusageChanges Made
packages/components/src/ui/calendar.tsx:getDefaultClassNamesfrom importsconst defaultClassNames = getDefaultClassNames()callsclassNamesproperties to use direct class strings instead of merging withdefaultClassNamesTesting
✅ Build passes successfully (
yarn buildin packages/components)✅ Calendar component compiles without errors
✅ All existing styling is preserved
Compatibility
This fix ensures compatibility with:
Resolves the build error reported by Jake Ruesink for projects using
@lambdacurry/formsv0.19.0.💻 View my work • About Codegen
⛔ Remove Codegen from PR • 🚫 Ban action checks
Summary by CodeRabbit
Style
Chores