Skip to content

Implement nuqs and zod filters for DataTableRouterForm#48

Merged
jaruesink merged 6 commits intocodegen-data-table-lc187from
codegen-data-table-nuqs-zod-lc190
Apr 2, 2025
Merged

Implement nuqs and zod filters for DataTableRouterForm#48
jaruesink merged 6 commits intocodegen-data-table-lc187from
codegen-data-table-nuqs-zod-lc190

Conversation

@codegen-sh
Copy link
Copy Markdown
Contributor

@codegen-sh codegen-sh Bot commented Apr 1, 2025

This PR updates the DataTableRouterForm component to implement URL-based state management with nuqs and schema validation with zod as requested in LC-190.

Changes

  1. Added nuqs dependency for URL-based state management
  2. Implemented zod schema validation for filter inputs
  3. Created custom hooks for managing URL state:
    • useDataTableUrlState for managing filter state in the URL
    • Debounced search inputs for better performance
  4. Updated components to work with URL state:
    • DataTableRouterForm now uses URL state for filters, sorting, and pagination
    • DataTableRouterToolbar uses debounced search inputs
    • DataTableFacetedFilter works with URL state
  5. Added schema validation with zod:
    • Created base schema for common filter parameters
    • Dynamic schema generation based on column configuration
    • Type-safe filter parameters

Features

  • Filters persist across page refreshes via URL state
  • Debounced search inputs for better performance
  • Type-safe filter parameters with zod validation
  • Faceted filters with proper URL state
  • Pagination state maintained in the URL

This implementation follows the patterns from the reference repositories (kianbazza/ui and openstatusHQ/data-table-filters) while maintaining compatibility with the existing implementation.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 1, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jaruesink jaruesink changed the base branch from main to codegen-data-table-lc187 April 1, 2025 20:40
… in data table components and enhance DataTableRouterForm with improved filtering and pagination features. Refactor data table components for better clarity and consistency, including removal of unused files.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2025

📝 Storybook Preview: View Storybook

This preview will be updated automatically when you push new changes to this PR.

Note: The preview will be available after the workflow completes and the PR is approved for deployment.

@jaruesink jaruesink marked this pull request as ready for review April 2, 2025 05:58
@jaruesink jaruesink merged commit 3221e2c into codegen-data-table-lc187 Apr 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant