Add custom Input component support to TextField#55
Conversation
|
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hey! 👋 I see one of the checks failed. I am on it! 🫡 |
|
📝 Storybook Preview: View Storybook This preview will be updated automatically when you push new changes to this PR.
|
|
Hey! 👋 I see one of the checks failed. I am on it! 🫡 |
|
I've fixed the failing check suite in PR #55. The issue was related to the TextField component's implementation of custom Input components. The changes I made:
These changes ensure that custom Input components are properly typed and handled throughout the component hierarchy, which should resolve the test failures. The fix has been pushed to the original PR branch. 💻 View my work • React 👍 or 👎 |
… component to accept a more flexible Input prop type.
- Update package version in components to reflect recent changes.
This PR updates the TextField component to support custom Input components via the
componentsprop.Changes:
componentspropImplementation Details:
components?.Inputand uses it if available, otherwise falls back to the default TextInputReact.forwardRefto properly forward refs to the input elementThis enhancement allows for greater flexibility and customization of the TextField component, making it easier to create custom form inputs while maintaining the form functionality.
💻 View my work • About Codegen