Skip to content

Conversation

@codegen-sh
Copy link
Contributor

@codegen-sh codegen-sh bot commented May 20, 2025

Issue

useFilterSync returns a setFilters function typed to take a filter array only, but useDataTableFilters calls this setter with functional updates (setFilters(prev => ...)). This causes the filter state to break because useFilterSync receives a function instead of a filter array and tries to serialize this function, producing invalid query parameters.

Changes

  • Updated the useFilterSync hook to support functional updates by:
    • Modifying the type signature to accept either a direct BazzaFiltersState or a function that takes the previous state and returns a new state
    • Adding logic to detect if the input is a function and resolve it with the current filters
    • Updating the dependency array to include filtersFromUrl to ensure the latest filter state is used

Testing

This change ensures that when useDataTableFilters calls setFilters with a functional update, the function is properly resolved with the current filter state before being serialized to URL parameters.

Fixes the issue where selecting filters triggers a page reload but no filters are applied or displayed.


💻 View my workAbout Codegen

Summary by CodeRabbit

  • New Features

    • Enhanced filter management to support both direct updates and functional updates based on previous filter states.
  • Bug Fixes

    • Improved synchronization of filters with the URL to ensure more reliable updates.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented May 20, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The useFilterSync hook was updated so its setter function can now accept either a direct filter state or a function that computes the new state from the previous one. The internal logic resolves functional updaters and updates the URL parameters accordingly. The hook's TypeScript signature was also modified to reflect this expanded setter capability.

Changes

File(s) Change Summary
packages/components/src/ui/utils/use-filter-sync.ts Enhanced setFilters to accept direct state or functional updaters; updated logic to resolve functions; adjusted TypeScript types and dependencies.

Poem

A hop and a skip, our filters now sing,
With functions or states, updates they bring.
URLs in sync, with every new tweak,
The code's more robust, not brittle or weak.
So cheers to the hook, now clever and spry—
More flexible filters, as time hops by! 🐇✨

✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch codegen-bot/fix-useFilterSync-functional-updates
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

📝 Storybook Preview: View Storybook

This preview will be updated automatically when you push new changes to this PR.

Note: The preview will be available after the workflow completes and the PR is approved for deployment.

@jaruesink
Copy link
Contributor

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented May 20, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jaruesink jaruesink marked this pull request as ready for review May 20, 2025 04:38
@jaruesink jaruesink merged commit 47f7768 into bazza-filters May 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants