-
Notifications
You must be signed in to change notification settings - Fork 0
Fix useFilterSync to support functional updates #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix useFilterSync to support functional updates #67
Conversation
|
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the WalkthroughThe Changes
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
📝 Storybook Preview: View Storybook This preview will be updated automatically when you push new changes to this PR.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Issue
useFilterSyncreturns asetFiltersfunction typed to take a filter array only, butuseDataTableFilterscalls this setter with functional updates (setFilters(prev => ...)). This causes the filter state to break becauseuseFilterSyncreceives a function instead of a filter array and tries to serialize this function, producing invalid query parameters.Changes
useFilterSynchook to support functional updates by:BazzaFiltersStateor a function that takes the previous state and returns a new statefiltersFromUrlto ensure the latest filter state is usedTesting
This change ensures that when
useDataTableFilterscallssetFilterswith a functional update, the function is properly resolved with the current filter state before being serialized to URL parameters.Fixes the issue where selecting filters triggers a page reload but no filters are applied or displayed.
💻 View my work • About Codegen
Summary by CodeRabbit
New Features
Bug Fixes