Skip to content

Fix useFilterSync to support functional updates #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Fix useFilterSync to support functional updates #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions packages/components/src/ui/utils/use-filter-sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,24 @@ import { dataTableRouterParsers } from '../../remix-hook-form/data-table-router-
*
* @returns A tuple containing the current filter state and a function to update it
*/
export function useFilterSync(): [BazzaFiltersState, (newFilters: BazzaFiltersState) => void] {
export function useFilterSync(): [BazzaFiltersState, (newFilters: BazzaFiltersState | ((prev: BazzaFiltersState) => BazzaFiltersState)) => void] {
const [searchParams, setSearchParams] = useSearchParams();

// Parse filters from URL
const filtersFromUrl = dataTableRouterParsers.filters.parse(searchParams.get('filters'));

// Function to update filters in URL
const setFilters = useCallback((newFilters: BazzaFiltersState) => {
const setFilters = useCallback((newFilters: BazzaFiltersState | ((prev: BazzaFiltersState) => BazzaFiltersState)) => {
// Handle functional updates by resolving the function with current filters
const resolvedFilters = typeof newFilters === 'function'
? newFilters(filtersFromUrl)
: newFilters;

const newParams = new URLSearchParams(searchParams);

// Update or remove the filters parameter
if (newFilters.length > 0) {
const serialized = dataTableRouterParsers.filters.serialize(newFilters);
if (resolvedFilters.length > 0) {
const serialized = dataTableRouterParsers.filters.serialize(resolvedFilters);
if (serialized !== null) {
newParams.set('filters', serialized);
}
Expand All @@ -33,8 +38,7 @@ export function useFilterSync(): [BazzaFiltersState, (newFilters: BazzaFiltersSt

// Update the URL with the new search parameters
setSearchParams(newParams, { replace: true });
}, [searchParams, setSearchParams]);
}, [searchParams, setSearchParams, filtersFromUrl]);

return [filtersFromUrl, setFilters];
}