Skip to content

fix(medusa-forms): Fix package exports and bump version to 0.2.1#89

Merged
jaruesink merged 2 commits intomainfrom
codegen-bot/fix-medusa-forms-exports-31035
Jun 3, 2025
Merged

fix(medusa-forms): Fix package exports and bump version to 0.2.1#89
jaruesink merged 2 commits intomainfrom
codegen-bot/fix-medusa-forms-exports-31035

Conversation

@codegen-sh
Copy link
Copy Markdown
Contributor

@codegen-sh codegen-sh bot commented Jun 3, 2025

Summary

Fixes the @lambdacurry/medusa-forms package export issues that were causing build errors when importing the package.

Changes Made

  • Created missing src/index.ts - Main entry point that re-exports all controlled and ui components
  • Removed leftover remix entry from vite.config.ts (was referencing non-existent files)
  • Bumped version from 0.2.0 to 0.2.1
  • Verified build process - Package now builds successfully and generates dist/index.js

Problem Solved

This resolves the commonjs resolver error:

Failed to resolve entry for package "@lambdacurry/medusa-forms". 
The package may have incorrect main/module/exports specified in its package.json.

The issue was that package.json expected dist/index.js to exist, but there was no src/index.ts source file to build from.

Files Changed

  • packages/medusa-forms/src/index.ts - New file that exports from controlled and ui modules
  • packages/medusa-forms/vite.config.ts - Removed remix entry from build configuration
  • packages/medusa-forms/package.json - Version bump to 0.2.1

Testing

✅ Build process verified - yarn build completes successfully and generates all expected dist files including dist/index.js


💻 View my workAbout Codegen

- Create missing src/index.ts to serve as main entry point
- Remove leftover remix entry from vite.config.ts
- Re-export all controlled and ui components from main index
- Bump version from 0.2.0 to 0.2.1
- Resolves commonjs resolver error for @lambdacurry/medusa-forms package
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 3, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 3, 2025

📝 Storybook Preview: View Storybook

This preview will be updated automatically when you push new changes to this PR.

Note: The preview will be available after the workflow completes and the PR is approved for deployment.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codegen-sh instead of having this barrel file can we just export the controlled folder?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review the export approach for you! 🔍

💻 View my work

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! ✅ I've updated the main export to only include the controlled components as requested.

🔄 Updated PR #89 now exports only from './controlled' in the main index.ts file.

What this means:

  • import { ControlledInput } from '@lambdacurry/medusa-forms' ✅ (controlled components)
  • import { Input } from '@lambdacurry/medusa-forms/ui' ✅ (ui components via subpath)

The package is now more focused with the main export containing only the controlled form components, while UI components remain accessible through the /ui subpath export. The build is working perfectly! 🎯

💻 View my work • React 👍 or 👎

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood! I'll remove the barrel file completely 🗑️

💻 View my work

- Changed src/index.ts to export only from './controlled'
- Removes ui components from main package export
- UI components still available via '@lambdacurry/medusa-forms/ui' subpath
@jaruesink jaruesink marked this pull request as ready for review June 3, 2025 06:21
@jaruesink jaruesink merged commit 3c94e29 into main Jun 3, 2025
5 checks passed
@codegen-sh
Copy link
Copy Markdown
Contributor Author

codegen-sh bot commented Jun 3, 2025

✅ Done! I've completely removed the barrel file as requested.

What changed:

  • 🗑️ Deleted src/index.ts barrel file completely
  • 🚫 Removed main entry point from package.json
  • 🔧 Updated vite.config.ts to build only controlled and ui modules separately

New import structure:

  • import { ControlledInput } from '@lambdacurry/medusa-forms/controlled'
  • import { Input } from '@lambdacurry/medusa-forms/ui'
  • import { anything } from '@lambdacurry/medusa-forms' ❌ (no longer available)

The package is now more explicit - users must import from specific subpaths, which provides better tree-shaking and clearer intent! 🎯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant