Skip to content

Fix input select #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaruesink merged 3 commits into from
Jun 29, 2023
Merged

Fix input select #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7fa07d
fix(input-select): infinite loop when value is an array. Use lodash i…
dwene Jun 29, 2023
540b2d9
chore: cleanup
dwene Jun 29, 2023
c7ad82d
fix(lockfile)
dwene Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/ui-components/src/lib/inputs/InputSelect/InputSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ export const InputSelect: FC<InputSelectProps> = ({
// Note: We had to use a `useEffect` here to handle cases where the form is reset or manipulated outside of the input
// For some reason setting the initialInputValue in the initial useState did not reset the input on a form reset
useEffect(() => {
if (_isEqual(controlledValue, value)) return;

setValue(controlledValue);
}, [controlledValue]);

Expand Down Expand Up @@ -298,9 +300,10 @@ export const InputSelect: FC<InputSelectProps> = ({
// Allows the input to keep it's value when the user selects an option when disableCloseOnSelect is true
if (isMultiselect && autocompleteProps.disableCloseOnSelect) {
autocompleteProps.inputValue = inputValue;
const existingOnBlur = autocompleteProps.onBlur;
autocompleteProps.onBlur = event => {
setInputValue('');
if (autocompleteProps.onBlur) autocompleteProps.onBlur(event);
Copy link
Contributor Author

@dwene dwene Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was causing an infinite recursive function. We need to pun the function as a const before overwriting it.

if (inputValue) setInputValue('');
if (existingOnBlur) existingOnBlur(event);
};
}

Expand Down
17 changes: 16 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16743,13 +16743,20 @@ postcss-modules@^4.0.0:
postcss-modules-values "^4.0.0"
string-hash "^1.1.1"

postcss-nested@*, postcss-nested@6.0.0, postcss-nested@^6.0.0:
postcss-nested@*, postcss-nested@6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/postcss-nested/-/postcss-nested-6.0.0.tgz#1572f1984736578f360cffc7eb7dca69e30d1735"
integrity sha512-0DkamqrPcmkBDsLn+vQDIrtkSbNkv5AD/M322ySo9kqFkCIYklym2xEmWkwo+Y3/qZo34tzEPNUw4y7yMCdv5w==
dependencies:
postcss-selector-parser "^6.0.10"

postcss-nested@^6.0.1:
version "6.0.1"
resolved "https://registry.yarnpkg.com/postcss-nested/-/postcss-nested-6.0.1.tgz#f83dc9846ca16d2f4fa864f16e9d9f7d0961662c"
integrity sha512-mEp4xPMi5bSWiMbsgoPfcP74lsWLHkQbZc3sY+jWYd65CUwXrUaTp0fmNpa01ZcETKlIgUdFN/MpS2xZtqL9dQ==
dependencies:
postcss-selector-parser "^6.0.11"

postcss-normalize-charset@^5.0.1:
version "5.0.1"
resolved "https://registry.yarnpkg.com/postcss-normalize-charset/-/postcss-normalize-charset-5.0.1.tgz#121559d1bebc55ac8d24af37f67bd4da9efd91d0"
Expand Down Expand Up @@ -16987,6 +16994,14 @@ postcss-selector-parser@^6.0.10:
cssesc "^3.0.0"
util-deprecate "^1.0.2"

postcss-selector-parser@^6.0.11:
version "6.0.13"
resolved "https://registry.yarnpkg.com/postcss-selector-parser/-/postcss-selector-parser-6.0.13.tgz#d05d8d76b1e8e173257ef9d60b706a8e5e99bf1b"
integrity sha512-EaV1Gl4mUEV4ddhDnv/xtj7sxwrwxdetHdWUGnT4VJQf+4d05v6lHYZr8N573k5Z0BViss7BDhfWtKS3+sfAqQ==
dependencies:
cssesc "^3.0.0"
util-deprecate "^1.0.2"

postcss-selector-parser@^6.0.9:
version "6.0.10"
resolved "https://registry.yarnpkg.com/postcss-selector-parser/-/postcss-selector-parser-6.0.10.tgz#79b61e2c0d1bfc2602d549e11d0876256f8df88d"
Expand Down