Avoid importing alloc::sync on platforms that do not have it#492
Merged
lambda-fairy merged 4 commits intolambda-fairy:mainfrom Apr 6, 2026
Merged
Avoid importing alloc::sync on platforms that do not have it#492lambda-fairy merged 4 commits intolambda-fairy:mainfrom
alloc::sync on platforms that do not have it#492lambda-fairy merged 4 commits intolambda-fairy:mainfrom
Conversation
Owner
|
Thanks! Happy to take a PR that adds a |
Contributor
Author
Yay! I've opened #495 to that effect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to test another crate (which depends on
maud) underno_stdconditions, I found that this won't compile as-is on my go-to baseline target for that (usuallythumbv6m-none-eabi), due to a lack of atomic pointer support. (thumbv7m-none-eabiseems to work fine however.)Since
maudonly seems to importArcto add aRenderimpl, I suppose it wouldn't affect anything to simply move that impl block behind an appropriatecfgattribute so it won't be included when building for affected platforms. This PR does just that.In terms of tests, I could add a CI step to try building against
thumbv6m-none-eabiif you'd like, but I figured I'd ask on that one, sinceno_stdsupport seems to work well here otherwise.