Skip to content

Tr100 restore case functionality #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KarlLundengaard merged 5 commits into from
Sep 4, 2023
Merged

Tr100 restore case functionality #7

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98d4bd6
Updated tests to look for matched_case
KarlLundengaard Aug 22, 2023
fb677c3
Revert "Updated tests to look for matched_case"
KarlLundengaard Sep 1, 2023
e1ae6db
Revert "The lambda backend expects 'matched_case'"
KarlLundengaard Sep 1, 2023
4d7706e
Revert "Revert "Updated tests to look for matched_case""
KarlLundengaard Sep 4, 2023
2dcce02
Revert "Revert "The lambda backend expects 'matched_case'""
KarlLundengaard Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tests/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def test_single_feedback_case(self):
result = response["result"] # type: ignore

self.assertTrue(result["is_correct"])
self.assertNotIn("match", result)
self.assertNotIn("matched_case", result)
self.assertNotIn("feedback", result)

def test_single_feedback_case_match(self):
Expand All @@ -102,7 +102,7 @@ def test_single_feedback_case_match(self):
result = response["result"] # type: ignore

self.assertFalse(result["is_correct"])
self.assertEqual(result["match"], 0)
self.assertEqual(result["matched_case"], 0)
self.assertEqual(result["feedback"], "should be 'hello'.")

def test_case_warning_data_structure(self):
Expand Down Expand Up @@ -159,7 +159,7 @@ def test_multiple_feedback_cases_single_match(self):
result = response["result"] # type: ignore

self.assertFalse(result["is_correct"])
self.assertEqual(result["match"], 1)
self.assertEqual(result["matched_case"], 1)
self.assertEqual(result["feedback"], "should be 'yes'.")

def test_multiple_feedback_cases_multiple_matches(self):
Expand Down Expand Up @@ -191,7 +191,7 @@ def test_multiple_feedback_cases_multiple_matches(self):
result = response["result"] # type: ignore

self.assertFalse(result["is_correct"])
self.assertEqual(result["match"], 0)
self.assertEqual(result["matched_case"], 0)
self.assertEqual(result["feedback"], "should be 'hello'.")

def test_case_params_overwrite_eval_params(self):
Expand All @@ -216,7 +216,7 @@ def test_case_params_overwrite_eval_params(self):
result = response["result"] # type: ignore

self.assertTrue(result["is_correct"])
self.assertNotIn("match", result)
self.assertNotIn("matched_case", result)
self.assertNotIn("feedback", result)

def test_invalid_case_entry_doesnt_raise_exception(self):
Expand Down Expand Up @@ -312,7 +312,7 @@ def test_overriding_eval_feedback_to_correct_case(self):
result = response["result"] # type: ignore

self.assertTrue(result["is_correct"])
self.assertEqual(result["match"], 0)
self.assertEqual(result["matched_case"], 0)
self.assertEqual(result["feedback"], "should be 'hello'.")

def test_overriding_eval_feedback_to_incorrect_case(self):
Expand All @@ -336,7 +336,7 @@ def test_overriding_eval_feedback_to_incorrect_case(self):
result = response["result"] # type: ignore

self.assertFalse(result["is_correct"])
self.assertEqual(result["match"], 0)
self.assertEqual(result["matched_case"], 0)
self.assertEqual(result["feedback"], "should be 'hello'.")

def test_valid_preview_command(self):
Expand All @@ -345,7 +345,7 @@ def test_valid_preview_command(self):
response = commands.preview(event)
result = response["result"] # type: ignore

self.assertEqual(result["preview"], "hello")
self.assertEqual(result["preview"]["latex"], "hello")

def test_invalid_preview_args_raises_parse_error(self):
event = {"headers": "any", "other": "params"}
Expand Down