Added error message and feedback if answer or response is not a number#10
Merged
KarlLundengaard merged 1 commit intomasterfrom Jan 8, 2025
Conversation
KarlLundengaard
force-pushed
the
tr172-give-better-feedback-when-response-is-not-a-number
branch
from
d4e6210 to
47889ec
Compare
Member
peterbjohnson
left a comment
peterbjohnson
left a comment
There was a problem hiding this comment.
Looks good to me.
Have you tested this on a sample of responses from the DB and found where the feedback differs from previous efforts, and if the change is always favourable?
I can see the two tests added. Just wondering if there are any edge cases in the DB, i.e. that we should already know about.
Contributor
Author
|
I have now downloaded and ran almost all responses from the DB and did not find anything unfavourable changes. |
peterbjohnson
approved these changes
Jan 6, 2025
Member
|
@KarlLundengaard Great thanks. I've approved. You can merge. If there's an easy way to report the changes that you did find, that would be interesting to see. Not critical though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix will reduce the number of errors from questions that use IsSimilar.