Skip to content

Found a way to solve the original problem without generating code for… #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KarlLundengaard merged 1 commit into from
Jan 7, 2025
Merged

Found a way to solve the original problem without generating code for… #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/preview_utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,17 +89,13 @@ def parse_latex(response: str, symbols: SymbolDict, simplify : bool, parameters=
raise ValueError(str(e))

if (pm_placeholder is not None) or (mp_placeholder is not None):
result_str_set = set()
result_str = str(expression)
for ph in [(pm_placeholder, "plus_minus"), (mp_placeholder, "minus_plus")]:
if ph[0] is not None:
result_str = result_str.replace("*"+ph[0]+"*", " "+ph[1]+" ")
result_str = result_str.replace(ph[0]+"*", " "+ph[1]+" ")
result_str = result_str.replace("*"+ph[0], " "+ph[1]+" ")
result_str = result_str.replace(ph[0], " "+ph[1]+" ")
for expr in create_expression_set(result_str, parameters):
result_str_set.add(expr)
result_str = '{'+', '.join(result_str_set)+'}'
else:
result_str = str(expression.xreplace(substitutions))

Expand Down
2 changes: 1 addition & 1 deletion app/symbolic_comparison_preview_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def test_latex_with_plus_minus(self):
)
result = preview_function(response, params)
preview = result["preview"]
assert preview.get("sympy") in ['{3*i/sqrt(5), - 3*i/sqrt(5)}', '{- 3*i/sqrt(5), 3*i/sqrt(5)}']
assert preview.get("sympy") == ' plus_minus 3*i/sqrt(5)'
assert preview.get("latex") == r'\pm \frac{3}{\sqrt{5}} i'

def test_latex_conversion_preserves_default_symbols(self):
Expand Down