Fixed E being parsed as Eulers in preview #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slightly hacky fix for
Ebeing parsed asEinstead of Euler's when using latex2sympy.Before this PR:
After this PR:
Issues which resulted in this fix:
Ehard-coded as Euler's in its tokens - would have to change the lexer to fix thisEEEorSym_{E}E, it simplifies the expression, and results in other tests failing. And does not have any way of disabling this reliably.I decided that in preview that all instances of
Ecan be parsed asEinstead of Euler's in Sympy. As in the preview, we are only checking if it parses, not if it is correct. SinceEis passed to the evaluation function as a string, the evaluation side can then treat it as Euler's if required. If preferred, we can do this only whenelementary_functionsis disabled.If you can think of any test cases that might break this approach, please let me know, and I will add them.