Merged
Conversation
| # we need to make sure it is not substituted back in | ||
| substitutions = [(original, subs.replace("lambda", "lamda")) for (original, subs) in substitutions] | ||
|
|
||
| # Since 'as' is a reserved keyword in python, we add a subsitution of 'as' to 'a*s' if 'as' is not a defined symbol |
Member
There was a problem hiding this comment.
If more reserved words emerge:
- Could we anticipate them? Can we find a list of Python reserved words?
- Would it make sense to group the treatment rather than adding them one at a time?
Member
Author
There was a problem hiding this comment.
Will add this to the backlog to refactor
peterbjohnson
approved these changes
Jan 15, 2026
Member
peterbjohnson
left a comment
peterbjohnson
left a comment
There was a problem hiding this comment.
Looks good. I've made comments that I suggest you act on. But I'm approving so that you don't need further review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
compareExpressions unable to correctly parse
asasa*sas Python has an in-built 'as' function and these are parsed first before mathematical symbols. The same issue that we have with 'lambda'.Fix: Following the same fix for
lambda, added a substitution which substitutesasfora*sifasis not in theinput_symbollist. If it is, then Sympy will treatasas a Symbol. Added tests to preview and evaluate to validate that it works as intended.