Dicussion : Refactor the winit crate module#29
Merged
Conversation
Refactored the name of `EventLoopPublisher` in the winit crate module, to simply `LoopPublisher`, keeping in line with the other abstraction, `Loop`.
1. Add a LoopBuilder for consistency. 2. Add a WindowHandleBuilder 3. Add from method in LoopPublisher 4. Add TODOS to remove/review changes, and older functions.
vmarcella
reviewed
Jun 3, 2022
Contributor
Author
|
Should we modify the |
…s above 20 milliseconds.
vmarcella
approved these changes
Oct 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR serves as a discussion log for proceedings on what the goals of the refactor are and how it should generally be carried out in actionable steps.
The primary goal as of now is to refactor the module to use the builder pattern, same as the
gfx-halrefactoring.