Skip to content

Code cleanup & adding tests#39

Merged
vmarcella merged 25 commits into
mainfrom
vmarcella/refactoring-and-testing
Oct 15, 2022
Merged

Code cleanup & adding tests#39
vmarcella merged 25 commits into
mainfrom
vmarcella/refactoring-and-testing

Conversation

@vmarcella
Copy link
Copy Markdown
Member

@vmarcella vmarcella commented Oct 9, 2022 •
edited
Loading

  • Adds tests to lambda-platform and updates github actions to run tests on Linux, MacOS, & Windows.
  • Adds both renderer & window configuration hooks for the generic runtime.
  • Added & Updated documentation across multiple modules
  • Fixed a bug where the surface wouldn't update due to render context not handling resize events from the window.
  • Refactored the demo application to import runtime commands directly and to resize the viewport by listening to resize events generated by the window running in GenericRuntime

vmarcella and others added 18 commits October 8, 2022 23:43
@vmarcella
[update] component rendering & documentation.
4db47d4
@vmarcella
[remove] unused function.
d92cedb
@vmarcella
[fix] panic that happened when virtual key representations weren't pr…
0422f75 
…esent.
@vmarcella
[update] error message.
299e5d4
@vmarcella
[update] print formatting.
ac49d73
@vmarcella
[update] event imports & update lambda-platform documentation.
d1d2962
@vmarcella
[add] documentation for gfx fences.
d27f5a5
@vmarcella
[add] test for viewport building.
6de1237
@vmarcella
[update] workflow to run tests for all platforms.
e8b8236
@vmarcella
[add] tests for builder with coordinates.
414d911
@vmarcella
[test] properties of the built viewport.
c5ccf30
@vmarcella
[update] documentation & tests.
579d666
@vmarcella
[update] the surface size to use a tuple.
9948be4
@vmarcella
[add] mockall for mocking in platform tests.
05b6dc0
@vmarcella
[add] mockall to lambda-platform, add a surface builder test.
c5426b6
@vmarcella
[add] tests for the swapchain builder.
d2db132
@vmarcella
[refactor] both the shader and shader assembler.
2926726
@vmarcella
[add] shader module tests.
b97dec9
@vmarcella vmarcella changed the title Vmarcella/refactoring and testing Code cleanup & adding tests Oct 11, 2022
KaranAhlawat
KaranAhlawat approved these changes Oct 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@KaranAhlawat KaranAhlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@vmarcella vmarcella merged commit 3de1c79 into main Oct 15, 2022
@vmarcella vmarcella deleted the vmarcella/refactoring-and-testing branch January 31, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KaranAhlawat KaranAhlawat KaranAhlawat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmarcella @KaranAhlawat