-
Notifications
You must be signed in to change notification settings - Fork 123
feat(l1,l2): add log messages for block building and execution throughput #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick and dirty implementation: - One atomic, updated after every block; - One getter; - One Tokio task fired by the main function in `ethrex` that queries the value every 30 seconds and logs as `info`.
- Log throughput at each block, discounting idle time; - Log counter overflows.
jrchatruc
approved these changes
Feb 24, 2025
JereSalo
pushed a commit
that referenced
this pull request
Feb 28, 2025
…hput (#1996) **Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number --------- Co-authored-by: Mario Rugiero <mrugiero@gmail.com> Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
fkrause98
added a commit
that referenced
this pull request
Mar 5, 2025
…hput (#1996) **Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number --------- Co-authored-by: Mario Rugiero <mrugiero@gmail.com> Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
fkrause98
added a commit
that referenced
this pull request
Mar 5, 2025
…hput (#1996) **Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number --------- Co-authored-by: Mario Rugiero <mrugiero@gmail.com> Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…hput (lambdaclass#1996) **Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes #issue_number --------- Co-authored-by: Mario Rugiero <mrugiero@gmail.com> Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Closes #issue_number