Skip to content

feat(l1): code cache rocksdb #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 19, 2025
Merged

feat(l1): code cache rocksdb #5307

merged 13 commits into from
Nov 19, 2025

Conversation

@pablodeymo
Copy link
Contributor

@pablodeymo pablodeymo commented Nov 12, 2025 •
edited by edg-l
Loading

Motivation

Adds a code cache to rocksdb, evicting the least used entries if size goes over 64mb

@github-actions github-actions bot added the L1 Ethereum client label Nov 12, 2025
@pablodeymo pablodeymo changed the title feat(l1): Code cache rocksdb feat(l1): code cache rocksdb Nov 12, 2025
@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited
Loading

Lines of code report

Total lines added: 69
Total lines removed: 0
Total lines changed: 69

Detailed view 
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/common/types/account.rs     | 228   | +6   |
+-------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/rocksdb.rs | 1715  | +63  |
+-------------------------------------------+-------+------+

@edg-l edg-l marked this pull request as ready for review November 18, 2025 10:51
@edg-l edg-l requested a review from a team as a code owner November 18, 2025 10:51
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Nov 18, 2025
Copilot AI review requested due to automatic review settings November 19, 2025 13:45
Copilot AI reviewed Nov 19, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

jrchatruc
jrchatruc previously requested changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@jrchatruc jrchatruc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge until we make sure we are properly managing any cache invalidation issues (contracts being destroyed, etc)

@github-project-automation github-project-automation bot moved this from In Review to In Progress in ethrex_l1 Nov 19, 2025
MegaRedHand
MegaRedHand reviewed Nov 19, 2025
View reviewed changes
@jrchatruc jrchatruc dismissed their stale review November 19, 2025 14:09

Addressed here 476ce99

@github-project-automation github-project-automation bot moved this from In Progress to In Review in ethrex_l1 Nov 19, 2025
@jrchatruc jrchatruc enabled auto-merge November 19, 2025 14:10
@jrchatruc jrchatruc mentioned this pull request Nov 19, 2025
Closed
@jrchatruc jrchatruc added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 6ef14c8 Nov 19, 2025
44 checks passed
@jrchatruc jrchatruc deleted the code_cache_rocksdb branch November 19, 2025 15:11
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Nov 19, 2025
@MegaRedHand MegaRedHand mentioned this pull request Nov 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Copilot code review Copilot Copilot left review comments

@jrchatruc jrchatruc jrchatruc approved these changes

Assignees

@pablodeymo pablodeymo

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablodeymo @MegaRedHand @jrchatruc @edg-l