feat: bind warn-on-block to debug-assertions #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
force-pushed
the
feat/warn-on-block-debug-assertions
branch
from
635fb5a to
80e3f51
Compare
Rationale: 1. `pin-project` only produces a few generics and introduces a few macros, meaning virtually no compile time or binary size overhead, so having it build inconditionally is not a problem; 2. Using a conditional feature means we need to propagate to the topmost manifest to actually use it; 3. It is reasonable enough to run this whenever we want extra checks, that is when we use `debug-assertions`. So, remove the feature, force the dependency and enable the check for debug-asserted builds.
Oppen
force-pushed
the
feat/warn-on-block-debug-assertions
branch
from
80e3f51 to
3fba5cf
Compare
MegaRedHand
approved these changes
Sep 11, 2025
| futures = "0.3.1" | ||
| thiserror = "2.0.12" | ||
| pin-project-lite = { version = "0.2", optional = true } | ||
| pin-project-lite = "0.2" |
There was a problem hiding this comment.
We should add a comment saying this is used only when debug_assertions is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
pin-projectonly produces a few generics and introduces a fewmacros, meaning virtually no compile time or binary size overhead, so
having it build inconditionally is not a problem;
manifest to actually use it;
that is when we use
debug-assertions.So, remove the feature, force the dependency and enable the check for
debug-asserted builds.