Skip to content

feat: log error on genserver crash #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

feat: log error on genserver crash #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions concurrency/src/tasks/gen_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ impl<G: GenServer> GenServerHandle<G> {
};
let handle_clone = handle.clone();
let inner_future = async move {
if gen_server.run(&handle, &mut rx).await.is_err() {
tracing::trace!("GenServer crashed")
if let Err(error) = gen_server.run(&handle, &mut rx).await {
tracing::trace!(%error, "GenServer crashed")
}
};

Expand All @@ -62,8 +62,8 @@ impl<G: GenServer> GenServerHandle<G> {
// Ignore the JoinHandle for now. Maybe we'll use it in the future
let _join_handle = rt::spawn_blocking(|| {
rt::block_on(async move {
if gen_server.run(&handle, &mut rx).await.is_err() {
tracing::trace!("GenServer crashed")
if let Err(error) = gen_server.run(&handle, &mut rx).await {
tracing::trace!(%error, "GenServer crashed")
};
})
});
Expand Down