Add nextjournal/beholder as an alternative watcher#268
Conversation
hawk is using an old version of JNA which breaks file watching on m1 macs. The alternative was to use :polling or :java but they were either too slow or consumed lots of battery beholder seems to be maintained, fast, and a much cleaner approach. figwheel has also shifted to using beholder instead of hawk. shadow-cljs also got rid of hawk maybe beholder should just replace hawk altogether?
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 75.62% 75.35% -0.28%
==========================================
Files 51 51
Lines 2659 2678 +19
Branches 246 250 +4
==========================================
+ Hits 2011 2018 +7
- Misses 495 503 +8
- Partials 153 157 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I guess the only thing we'd lose is the ability to fall back to polling, but hopefully no one is relying on that. |
|
I realize this is a draft, but I was already looking at Beholder's source and noticed something. Does Beholder have any options? Maybe we can delete that configuration option? |
we can remove hawk completely in a few versions, until then folks can manually configure `:kaocha.watch/type :hawk` to use hawk deprecation notice is warned when either hawk is configured or if hawk-opts are found in the config
Right now beholder has no configuration options
alysbrooks
left a comment
alysbrooks
left a comment
There was a problem hiding this comment.
Looks good! I have some small changes you can take or leave but nothing too major.
Co-authored-by: A Brooks <alys@gaiwan.co>
Co-authored-by: A Brooks <alys@gaiwan.co>
|
@alysbrooks Thanks for the suggestions, made those changes. Feel free to merge it in :) |
3 participants
hawk is using an old version of JNA which breaks file watching on m1 macs.
The alternative was to use :polling or :java but they were either too slow
or consumed lots of battery
beholder seems to be maintained, fast, and a much cleaner approach.
figwheel has also shifted to using beholder instead of hawk. shadow-cljs
also got rid of hawk
maybe beholder should just replace hawk altogether?
:kaocha.watch/type :hawkbut show DEPRECATED warningscc: #151 , thheller/shadow-cljs@f3b89b5 , bhauman/figwheel-main#299