fix: preserve per-build :js-options in merged-shadow-config#18
Merged
plexus merged 2 commits intolambdaisland:mainfrom Mar 4, 2026
Merged
fix: preserve per-build :js-options in merged-shadow-config#18plexus merged 2 commits intolambdaisland:mainfrom
plexus merged 2 commits intolambdaisland:mainfrom
Conversation
plexus
reviewed
Mar 4, 2026
| true | ||
| (assoc :build-id build-id) | ||
| (not= "" module-path) | ||
| (update :js-options merge {:js-package-dirs [(str module-path "/node_modules")]}))]))) |
Member
There was a problem hiding this comment.
tiny nitpick that this could have been (update :js-options assoc :js-package-dirs ...). But PR looks good, thanks!
Member
|
Released in v0.48.215-alpha [com.lambdaisland/launchpad "0.48.215-alpha"] ;; deps.edn
{com.lambdaisland/launchpad {:mvn/version "0.48.215-alpha"}} ;; project.clj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merged-shadow-configunconditionally replaces each build's:js-optionswith{}for the root project or{:js-package-dirs [...]}for submodules. Thiswipes out any per-build
:js-optionsdefined inshadow-cljs.edn.This breaks projects that use
:js-provider :externalwith:external-index,because shadow-cljs never sees those options and falls back to the default
:shadowprovider — silently skipping generation of the external index file.Fix
:js-optionsat all (there's nothing to add)mergeinto existing:js-optionsinstead of replacing,so
:js-package-dirsis added while preserving existing keysBefore
After
I also updated the CHANGELOG with the fix. Please let me know if anything else is needed. Thank you for this great project!