Fix modified elm.json bug introduced in #46 #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supermario
requested changes
Oct 23, 2025
builder/src/Build.hs
Outdated
| crawlDeps env mvar deps (SOutsideOk local source modul) | ||
| Lamdera.alternativeImplementationWhen (lamderaIsLiveHarnessModule modul) | ||
| (crawlDeps (lamderaLiveHarnessEnv env) mvar deps (SOutsideOk local source modul)) $ | ||
| crawlDeps env mvar deps (SOutsideOk local source modul) |
Member
There was a problem hiding this comment.
Lets move our alternative to the end using & instead of $ to preserve the original line & minimise the diff.
Member
Author
There was a problem hiding this comment.
Love this 🙂 I'm a big fan of minimal diffs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#46 introduced the ability to use multiple modules in
LocalDev.elm. This was achieved by addingelm-stuff/lamderaas an extra source directory to theOutlinewhen reading the user'selm.jsonfile.Unfortunately, with commands like
lamdera install, the modified outline can sometimes be mistakenly written back to the filesystem. This can then result in errors like:With this change, the additional source directory is added later, specifically in the
Build.hsEnvdata structure, which is not written back to the filesystem. Additionally, the change only takes effect when theLocalDev.elmmodule is compiled, and not with commands likelamdera install.