Skip to content

Fix Iconv::substr nullable#36

Closed
Moln wants to merge 1 commit intolaminas:3.7.xfrom
Moln:fix/fix-substr-nullable
Closed

Fix Iconv::substr nullable#36
Moln wants to merge 1 commit intolaminas:3.7.xfrom
Moln:fix/fix-substr-nullable

Conversation

@Moln
Copy link
Copy Markdown
Contributor

@Moln Moln commented Nov 10, 2021

Q A
Documentation no
Bugfix yes
BC Break yes
New Feature no
RFC no
QA yes

Description

Fix iconv_substr() expects parameter 3 to be int

PHP: 7.4.25

$utf8StrWrapper = \Laminas\Stdlib\StringUtils::getWrapper('UTF-8');
$utf8StrWrapper->substr('test');
// TypeError: iconv_substr() expects parameter 3 to be int, null given 

Fix `iconv_substr()` expects parameter 3 to be int
Copy link
Copy Markdown
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires test additions

@Ocramius
Copy link
Copy Markdown
Member

Since this is a bugfix, it should perhaps target 3.6.x?

@Moln Moln changed the base branch from 3.7.x to 3.6.x November 10, 2021 08:48
@Moln Moln changed the base branch from 3.6.x to 3.7.x November 10, 2021 08:48
@Moln
Copy link
Copy Markdown
Contributor Author

Moln commented Nov 10, 2021

Since this is a bugfix, it should perhaps target 3.6.x?

Close and will re-create PR for 3.6.x.

@Moln Moln closed this Nov 10, 2021
@Moln Moln deleted the fix/fix-substr-nullable branch November 10, 2021 09:21
@Ocramius
Copy link
Copy Markdown
Member

Moved to #37

@Ocramius Ocramius added the Duplicate This issue or pull request already exists label Nov 10, 2021
@Ocramius Ocramius added this to the 3.6.1 milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting Author Updates Bug Something isn't working Duplicate This issue or pull request already exists Unit Test Needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants