Merged
Conversation
- But not tagged releases.
Allow travis to build against the 2.7 branch.
Overrides the zend-hydrator plugins to use the extensions provided in this repository. This preserves the original typehints, allowing developers to gradually migrate by replacing zend-stdlib typehints with zend-hydrator typehints.
As noted in zendframework/zendframework#7672, on updating to: - zend-stdlib >= 2.7.0 - zend-mvc >= 2.6.0 backwards compatibility is broken with regards to typehints against hydrators. The reason is two-fold: - The `HydratorPluginManager` is simply an extension of the one provided in zend-hydrator, meaning that all plugins returned are under the `Zend\Hydrator` namespace, not the `Zend\Stdlib\Hydrator` namespace. - zend-mvc altered the `HydratorPluginManager` mapping to use the instance from zend-hydrator instead of zend-stdlib. This patch addresses the first point of each. It does the following: - Updates the DelegatingHydratorFactory to return a zend-stdlib instance. - Updates the HydratorPluginManager to override the defaults from zend-hydrator, and have them return zend-stdlib extensions. - Adds a test suite for HydratorPluginManager to verify backwards compatibility. A related commit against the zend-mvc 2.6 series will occur shortly, having it use the zend-stdlib HydratorPluginManager.
- Added `COMPOSER_ROOT_VERSION` directive to composer install, to ensure we don't get a circular dependency issue. - PHP 7 MUST pass!
Per #55 (and originally reported as zendframework/zend-hydrator#19), this patch does the following: - Adds tests against the hydrate and extract methods to ensure that the event triggered is the zend-stdlib variant (as well as kept the tests for the zend-hydrator variants). - Updated test expectations to check for `triggerEvent()` (and not `trigger()`), as the 1.1 version of zend-hydrator is now forwards-compatible with zend-eventmanager v3. This also required raising the minimum version of zend-hydrator to 1.1 so that tests do not need to be varied. - Fixes the test assumptions in `testAdd()`, as attachment of the aggregate listener now calls the `attach()` method of the listener class, changing how the mock EM instance is called.
When updating zend-hydrator to 1.1, we discovered some testing issues with the underlying functionality; additionally, due to the fact that the `createService()` method of the factory delegates to the `__invoke()` method, and the typehints are different (former uses ServiceLocatorInterface, while latter uses ContainerInterface), and the fact that the DelegatingHydrator constructor now accepts a ContainerInterface (vs ServiceLocatorInterface), prophecy had to be used to allow composing multiple interfaces in the mock object.
Close #56 Fixes #55 Fixes zendframework/zend-hydrator#19
This commit refers to the issue #58 and fixes an exception that was arising up on systems based on MUSL (and probably other UNIX based rather than GNU Linux) ``` [Exception] Notice: Use of undefined constant GLOB_BRACE - assumed 'GLOB_BRACE' in /magento/vendor/zendframework/zend-stdlib/src/Glob.php on line 64 ```
This patch allows the 2.7 series to work without errors on PHP 7.3. and 7.4. To make this possible, it makes the following changes: - Drops support for PHP versions prior to 5.6; we cannot test against those at this time. - Adds the Laminas CI and automatic-releases workflows to the 2.7.x branch, to allow testing and releasing on that branch. - It removes the existing Travis-CI configuration at the same time. - Updates the PHPUnit version so we can test against 5.6 and the entire 7.x series. - Removes the CHANGELOG file; changelogs will be kept in milestone descriptions, and propagated to tag and release notes. - Updates `ArrayObject::count()` to test if the internal storage is countable before it attempts to return its count; if not, it returns 1. - Updates `Parameters::toString()` to have it call `http_build_query()` on the return value of `toArray()` instead of on `$this`. - Updates unit tests to extend the namespaced variant of `PHPUnit\Framework\TestCase` instead of the pseudo-namespaced version. - Updates unit tests to use `createMock()` or `getMockBuilder(...)->getMock()` instead of `getMock()`. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
- Bumps laminas-eventmanager to 2.6.1 to pickup the `triggerEvent()` method. - Bumps laminas-servicemanager to 2.7.5/3.0.3 to pickup container-interop compatability. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
To pick up `is_countable()`. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
fix: fix unit tests by bumping minimum supported dependency versions
Signed-off-by: Anton Smirnov <sandfox@sandfox.me>
Signed-off-by: Anton Smirnov <sandfox@sandfox.me>
Signed-off-by: Anton Smirnov <sandfox@sandfox.me>
Signed-off-by: Anton Smirnov <sandfox@sandfox.me>
Fixes crash in `StringUtils::registerWrapper()`
…for testing registered wrappers
…ch that requirement
…omposer/composer:2.2.3` (re-generated, no dependency changes)
…ArrayAccess` caused by asymmetric property/getter access
Merge release 2.7.9 into 3.7.x
…()`, to comply with PHP 8.1 requirements Also marked any future detected deprecations as failures
…erator-php-8.1-deprecation Fix for #50 - added `ReturnTypeWillChange` to `ArrayStack#getIterator()`, to comply with PHP 8.1 requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes for 3.7.1
3.7.x bugfix release (patch)
3.7.1
Bug
ReturnTypeWillChangetoArrayStack#getIterator(), to comply with PHP 8.1 requirements thanks to @Ocramius and @alexgit2k