Skip to content

🐛 Properly treat subsetting by date #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2025
Merged

🐛 Properly treat subsetting by date #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions githubcontribs/_fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Fetcher:
Usage::

fetcher = Fetcher(org_name="my-org")
df = contribs.fetch()
df = contribs.run()
"""

def __init__(self, org_name: str, token: str = None):
Expand Down Expand Up @@ -78,14 +78,16 @@ def paginate_results(endpoint: str) -> list[dict]:
results = []
page: int = 1
while True:
params = {
"state": "all",
"page": page,
"per_page": 100,
"since": start_date_str, # For commits: filters by author date; for issues/PRs: filters by updated_at
}

response = self.session.get(
f"{self.base_url}/repos/{self.org_name}/{repo_name}/{endpoint}",
params={ # type: ignore
"since": start_date_str,
"state": "all",
"page": page,
"per_page": 100,
},
params=params, # type: ignore
)
if response.status_code == 404:
return []
Expand All @@ -112,6 +114,14 @@ def _fetch_contribs_per_repo(
"""Get commits, issues, and PRs for a specific repository since start_date as dataframes."""
commits, issues, prs = self._fetch_contribs_as_dicts(repo_name, start_date)

# Convert start_date for filtering issues and PRs
if isinstance(start_date, str):
start_date_dt = datetime.fromisoformat(start_date)
elif start_date is None:
start_date_dt = datetime.now() - timedelta(days=90)
else:
start_date_dt = start_date

data = []

for commit in commits:
Expand All @@ -132,6 +142,9 @@ def _fetch_contribs_per_repo(

for issue in issues:
created_date = issue["created_at"][:10]
# Filter by date - skip if created before start_date
if datetime.fromisoformat(created_date) < start_date_dt:
continue
data.append(
{
"date": created_date,
Expand All @@ -146,6 +159,9 @@ def _fetch_contribs_per_repo(

for pr in prs:
created_date = pr["created_at"][:10]
# Filter by date - skip if created before start_date
if datetime.fromisoformat(created_date) < start_date_dt:
continue
data.append(
{
"date": created_date,
Expand Down