Skip to content

Homogenize and clean tutorial 2#31

Merged
simongravelle merged 18 commits intomainfrom
improve-tutorial-2
Oct 14, 2024
Merged

Homogenize and clean tutorial 2#31
simongravelle merged 18 commits intomainfrom
improve-tutorial-2

Conversation

@simongravelle
Copy link
Copy Markdown
Member

@simongravelle simongravelle commented Oct 9, 2024

  • use \guicmd and \lmpcmd consistently in tutorial 2
  • replaced Berendsen by nose-hoover (for central group)
  • remove variable T in inputs
  • removed extra space in inputs
  • use Axel's representation for the CNT instead of the spheres
  • considerably simplified part B, breakable (because most of it is duplicate of part A, unbreakable)
  • increased the speed of the deformation in part B to reduce the computational cost
  • added symbolic links to avoid duplicating some files

image

@simongravelle simongravelle marked this pull request as draft October 10, 2024 11:27
@simongravelle
Copy link
Copy Markdown
Member Author

simongravelle commented Oct 10, 2024

Issues:

  • the variable Lcnt (formely L) is not updated in the GUI... I can't figure out why. I tried different names for the variable, different definition for Lcnt, different combinations for the thermo_style... Fcnt and all the other quantities are updated just fine.

image

@simongravelle simongravelle self-assigned this Oct 10, 2024
@simongravelle
Copy link
Copy Markdown
Member Author

Its a small thing, but now the tutorial2/solution folder contain some files that are within tutorial2, such as parameters.inc.

If we remove the parameters.inc from the tutorial2/solution folder, then the lammps input cannot be executed directly from tutorial2/solution.

If we remove the parameters.inc from tutorial2 folder, its going to mess up the setting up of the simulation.

@akohlmey, did you have something better in mind? Or do we accept that some files will be duplicated? Its not a huge deal, but of course it increases the chance of having future inconsistencies...

@akohlmey
Copy link
Copy Markdown
Collaborator

@akohlmey, did you have something better in mind? Or do we accept that some files will be duplicated? Its not a huge deal, but of course it increases the chance of having future inconsistencies...

You could make the duplicated entries in the solution folder symbolic links to the corresponding files in the '..' folder and thus minimize the risk of inconsistencies.

@simongravelle
Copy link
Copy Markdown
Member Author

You could make the duplicated entries in the solution folder symbolic links to the corresponding files in the '..' folder and thus minimize the risk of inconsistencies.

Yes! That would work. Perfect, thanks, I will try that.

@simongravelle simongravelle marked this pull request as ready for review October 12, 2024 15:26
@simongravelle
Copy link
Copy Markdown
Member Author

@akohlmey before I merge, I would like your opinion on 2 things:

  1. I did not include your tip to display bond with AIREBO force field within the main tutorial, but only as an extra tip at the end of the tutorial. Is it what you had in mind?

  2. The GUI does not show the variation of the CNT length (for neither unbreakable or breakable)... I can't figure out why, do you have an idea?

@akohlmey
Copy link
Copy Markdown
Collaborator

@akohlmey before I merge, I would like your opinion on 2 things:

  1. I did not include your tip to display bond with AIREBO force field within the main tutorial, but only as an extra tip at the end of the tutorial. Is it what you had in mind?

Yes. It is a rather elaborate hack and should eventually become obsolete, if I convince Steve to help me implement a proper solution: lammps/lammps#4268

  1. The GUI does not show the variation of the CNT length (for neither unbreakable or breakable)... I can't figure out why, do you have an idea?

This is (another) failure of the empirical code I've experimented with to drop outliers from the thermo data graphs. I am removing this now and will have to implement some kind of locking to avoid modifications of the cached thermo data while it is being read.

@akohlmey
Copy link
Copy Markdown
Collaborator

I've made a temporary version of the current LAMMPS-GUI code and uploaded it to https://download.lammps.org/testing/LAMMPS_GUI-Linux-amd64-29Aug2024.tar.gz
This will use the new download location for the tutorial files and has the outlier hack removed.

@akohlmey akohlmey self-requested a review October 14, 2024 03:41
@simongravelle simongravelle merged commit 329faed into main Oct 14, 2024
@simongravelle simongravelle deleted the improve-tutorial-2 branch October 14, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants