Skip to content

shared: support size suffix#154

Merged
fanatid merged 4 commits intomasterfrom
config-size
Nov 6, 2025
Merged

shared: support size suffix#154
fanatid merged 4 commits intomasterfrom
config-size

Conversation

@fanatid
Copy link
Member

@fanatid fanatid commented Nov 6, 2025

Closes #151

@fanatid fanatid requested a review from Copilot November 6, 2025 04:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for human-readable size suffixes (e.g., 4MiB, 16GiB) in configuration files by introducing the deserialize_humansize and deserialize_humansize_usize functions using the human-size crate. This makes configuration values more readable and easier to maintain.

  • Adds human-size dependency to parse size strings with suffixes
  • Replaces deserialize_num_str with deserialize_humansize_usize for size-related configuration fields
  • Updates configuration examples to use human-readable size format
  • Refactors deserialize_num_str implementation to use new parse() helper method

Reviewed Changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
shared/Cargo.toml Adds human-size dependency
shared/src/config.rs Implements size deserialization functions and refactors parsing logic
shared/src/transports/grpc.rs Updates max_decoding_message_size to use humansize deserializer
richat/src/pubsub/config.rs Updates message size fields to use humansize deserializer
richat/src/grpc/config.rs Updates stream buffer size fields to use humansize deserializer
richat/src/config.rs Updates max_bytes to use humansize deserializer
richat/config.yml Updates configuration examples with human-readable size values
plugin-agave/src/config.rs Updates max_bytes to use humansize deserializer
client/src/grpc.rs Updates max_decoding_message_size to use humansize deserializer
cli/src/track.rs Updates max_decoding_message_size to use humansize deserializer
Cargo.toml Updates workspace dependencies and internal crate versions
Cargo.lock Reflects dependency changes
CHANGELOG.md Documents the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

config:
max_messages: 2_097_152
max_bytes: 16_106_127_360
max_bytes: 16GiB
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion is incorrect. The original value 16_106_127_360 bytes equals 15 GiB (15 * 1024³), not 16 GiB. This should be max_bytes: 15GiB.

Suggested change
max_bytes: 16GiB
max_bytes: 15GiB

Copilot uses AI. Check for mistakes.
fanatid and others added 3 commits November 5, 2025 23:08
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Kirill Fomichev <kirill@raccoons.dev>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Kirill Fomichev <kirill@raccoons.dev>
@fanatid fanatid merged commit feba206 into master Nov 6, 2025
@fanatid fanatid deleted the config-size branch November 6, 2025 04:37
fanatid added a commit that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support 1gb 1gib syntax in config for size values

2 participants