Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for human-readable size suffixes (e.g., 4MiB, 16GiB) in configuration files by introducing the deserialize_humansize and deserialize_humansize_usize functions using the human-size crate. This makes configuration values more readable and easier to maintain.
- Adds
human-sizedependency to parse size strings with suffixes - Replaces
deserialize_num_strwithdeserialize_humansize_usizefor size-related configuration fields - Updates configuration examples to use human-readable size format
- Refactors
deserialize_num_strimplementation to use newparse()helper method
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| shared/Cargo.toml | Adds human-size dependency |
| shared/src/config.rs | Implements size deserialization functions and refactors parsing logic |
| shared/src/transports/grpc.rs | Updates max_decoding_message_size to use humansize deserializer |
| richat/src/pubsub/config.rs | Updates message size fields to use humansize deserializer |
| richat/src/grpc/config.rs | Updates stream buffer size fields to use humansize deserializer |
| richat/src/config.rs | Updates max_bytes to use humansize deserializer |
| richat/config.yml | Updates configuration examples with human-readable size values |
| plugin-agave/src/config.rs | Updates max_bytes to use humansize deserializer |
| client/src/grpc.rs | Updates max_decoding_message_size to use humansize deserializer |
| cli/src/track.rs | Updates max_decoding_message_size to use humansize deserializer |
| Cargo.toml | Updates workspace dependencies and internal crate versions |
| Cargo.lock | Reflects dependency changes |
| CHANGELOG.md | Documents the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| config: | ||
| max_messages: 2_097_152 | ||
| max_bytes: 16_106_127_360 | ||
| max_bytes: 16GiB |
There was a problem hiding this comment.
The conversion is incorrect. The original value 16_106_127_360 bytes equals 15 GiB (15 * 1024³), not 16 GiB. This should be max_bytes: 15GiB.
Suggested change
| max_bytes: 16GiB | |
| max_bytes: 15GiB |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Kirill Fomichev <kirill@raccoons.dev>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Kirill Fomichev <kirill@raccoons.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151