feat(ui): complete setup wizard flows through review + launch (#53/#54/#55/#56)#37
Merged
feat(ui): complete setup wizard flows through review + launch (#53/#54/#55/#56)#37
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 82.85% 82.85%
=======================================
Files 107 107
Lines 9658 9661 +3
=======================================
+ Hits 8002 8005 +3
Misses 1656 1656 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui/src/features/settings/storage/)ui/src/features/settings/detection/)ui/src/features/settings/notifiers/(backend registry + MQTT/SendGrid forms + typed state/validation)ui/src/features/settings/alerts/AlertPolicyForm.tsxTestConnectionButtonfor backend test-connection actionsui/src/features/setup/SetupPage.tsxui/src/features/setup/stepDrafts.tsform-checkbox-fieldminRiskLevelalert_policypayload entry builder/api/v1/setup/finalizeui/src/api/client.tsandui/src/api/parsing.tsuseFinalizeMutationhook and review payload/summary helpers inui/src/features/setup/review.tsReviewStep,ReviewSummaryCard, andLaunchProgresscomponents with:POST /api/v1/setup/finalize) and startup polling via setup statusshowNext+goToStep)Tests
ui/src/api/client.test.ts)ui/src/features/setup/review.test.ts)ui/src/features/setup/steps/LaunchProgress.test.tsx)ui/src/features/setup/steps/ReviewStep.test.tsx)useWizardState/SetupWizardShelltests)make ui-check(pass)Tickets
Follow-up Scope Added In This Branch
FinalizeRequest.validate_only, service-layer validate-only path that performs full merge+validation without config write/restartvalidate_only=trueprecheck, then real finalize), and abort-safe polling cancellation on unmount/navigationmake checkandmake ui-check(pass)