Skip to content

refactor: narrow api route dependency surfaces#50

Closed
lan17 wants to merge 2 commits intomainfrom
codex/api-dependency-narrowing
Closed

refactor: narrow api route dependency surfaces#50
lan17 wants to merge 2 commits intomainfrom
codex/api-dependency-narrowing

Conversation

@lan17
Copy link
Copy Markdown
Owner

@lan17 lan17 commented Apr 12, 2026

Summary

  • narrow API route dependencies from broad Application typing to route-specific protocol surfaces
  • move auth, mode, and database guards onto smaller protocol-based app dependencies
  • add focused dependency tests for minimal protocol-shaped app objects

Testing

  • TEST_DB_DSN=postgresql://homesec:homesec@localhost:5432/homesec_api_deps_ci make check

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.84%. Comparing base (298a5c5) to head (eaaa9a0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   83.73%   83.84%   +0.10%     
==========================================
  Files         110      110              
  Lines        9814     9858      +44     
==========================================
+ Hits         8218     8265      +47     
+ Misses       1596     1593       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lan17
Copy link
Copy Markdown
Owner Author

lan17 commented Apr 12, 2026

Closing this as a deliberate discard. The refactor was technically clean and validated, but after review it adds protocol/wrapper ceremony without enough maintainability payoff. We'll revisit API dependency narrowing only when it removes real route complexity or supports a broader API refactor.

@lan17 lan17 closed this Apr 12, 2026
@lan17 lan17 deleted the codex/api-dependency-narrowing branch April 12, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant