refactor: remove Simple executor implementation#147
Merged
ChunxuTang merged 2 commits intolance-format:mainfrom Mar 4, 2026
Merged
refactor: remove Simple executor implementation#147ChunxuTang merged 2 commits intolance-format:mainfrom
ChunxuTang merged 2 commits intolance-format:mainfrom
Conversation
Remove the legacy Simple executor to simplify the codebase and reduce maintenance burden. All queries now use the DataFusion planner, which provides better performance and more features. Changes: - Delete simple_executor module (724 lines across 5 files) - Remove ExecutionStrategy::Simple enum variant (breaking change) - Remove CypherQuery::execute_simple() method - Update all tests to use DataFusion execution - Update documentation and examples - Update Python bindings to remove Simple variant Breaking Changes: - Rust: ExecutionStrategy::Simple removed, use None or DataFusion - Python: ExecutionStrategy.Simple removed, use None or DataFusion All existing functionality is preserved - DataFusion supports all features that Simple did with better optimization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Run cargo fmt to fix formatting issues
- Remove empty impl CypherQuery {} block
- Remove unused ExecutionStrategy import from benchmarks
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ChunxuTang
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the legacy Simple executor to simplify the codebase and reduce maintenance burden. All queries now use the DataFusion planner, which provides better performance and more features.
Changes
Deleted (7 files, 724 lines)
simple_executor/module (5 files)test_simple_executor_pipeline.rstest fileModified (5 files)
execute_simple()method, and related code (~250 lines)Breaking Changes
Rust API:
ExecutionStrategy::Simpleenum variantCypherQuery::execute_simple()methodNoneorSome(ExecutionStrategy::DataFusion)Python API:
ExecutionStrategy.Simpleenum valueNoneorstrategy=ExecutionStrategy.DataFusionBehavior
Testing
✅ All 295 unit tests pass
✅ Package builds successfully
✅ No remaining references to Simple executor in codebase
Impact
Users passing
ExecutionStrategy::Simplewill need to update their code to use the default DataFusion strategy. This is acceptable as DataFusion provides strictly more features and better performance.