feat: add hive create namespace#154
Merged
Merged
Conversation
wojiaodoubao
force-pushed
the
hive-create-namespace
branch
from
bdccf76 to
00aed5a
Compare
geruh
reviewed
Jul 31, 2025
|
|
||
| public static void checkNotNullOrEmptyString(String str, String message, Object... args) { | ||
| public static String checkNotNullOrEmptyString(String str, String message, Object... args) { | ||
| checkArgument(str != null && !str.isEmpty(), message, args); |
Contributor
There was a problem hiding this comment.
This validation class may be skipping the lance namespace exceptions. We can probably address this later once we solidify them
Collaborator
There was a problem hiding this comment.
yeah we should probably change the ValidationUtil to return LanceNamespaceException, adding a tracking issue
jackye1995
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #156
Related to #92