Skip to content

Conversation

@jiaoew1991
Copy link
Collaborator

No description provided.

from .datasource import LanceDatasource


def read_lance(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this if we have upstream ray.data.read_lance?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can have both? the ray.data.read_lance will just call this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'm quite curious about is what features will be mainly developed here in the future based on Ray?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'm quite curious about is what features will be mainly developed here in the future based on Ray?

The PR submission process in the official Ray repo is too long, for example, @Jay-ju several bug fix PRs have not been merged for nearly two months 😁. We need faster iterations. This repo allows for faster iterations. Additionally, we have implemented distributed index building, distributed vector queries, and caching capabilities, which can also be gradually opened up in this repo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this if we have upstream ray.data.read_lance?

We may be able to use the official ray.data.read_lance as an alias for lance_ray.read_lance.

Copy link
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go 🚀

@jackye1995 jackye1995 merged commit adf0885 into lance-format:main Jul 3, 2025
@jackye1995
Copy link
Contributor

I added a few tasks in issues, let's get this in and iterate on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants